feat: TET-363 tag #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartaKozina010
temporarily deployed
to
development
GitHub Actions
Inactive
MartaKozina010
commented
Oct 2, 2023
kudyniuk
reviewed
Oct 3, 2023
src/components/Tag/Tag.styles.ts
Outdated
| label: BaseProps; | ||
| closeButton?: BaseProps; | ||
| }; | ||
| beforeComponent: { |
There was a problem hiding this comment.
beforeComponent should be in innerElements, and optional
kudyniuk
reviewed
Oct 3, 2023
mwleklinski
reviewed
Oct 3, 2023
src/components/Tag/Tag.styles.ts
Outdated
| label: BaseProps; | ||
| closeButton?: BaseProps; | ||
| }; | ||
| beforeComponent: { |
There was a problem hiding this comment.
I think it should also be optional, so that when user is passing the custom prop it won't require it
| state: (typeof states)[number]; | ||
| }) => ( | ||
| <tet.div flexBasis="120px" flexGrow="1" flexShrink="0"> | ||
| <Tag |
There was a problem hiding this comment.
I think Tag in TagDocs should be clickable to feel more "interactive" so I would pass some empty "onClick" here
kudyniuk
reviewed
Oct 3, 2023
| [onCloseClick], | ||
| ); | ||
|
|
||
| const containerRef = useRef<HTMLSpanElement | null>(null); |
There was a problem hiding this comment.
Move it before handleOnClose Click
kudyniuk
reviewed
Oct 3, 2023
| return { | ||
| container: { | ||
| ...container, | ||
| ...(hasOnClick ? hasOnClickStyles : {}), |
There was a problem hiding this comment.
Could be also ...(hasOnClick && hasOnClickStyles)
kudyniuk
reviewed
Oct 3, 2023
src/components/Tag/Tag.tsx
Outdated
| onClick={handleOnCloseClick} | ||
| state={state} | ||
| {...styles.closeButton} | ||
| data-testid="tag-icon-button" |
kudyniuk
reviewed
Oct 3, 2023
src/components/Tag/Tag.tsx
Outdated
| size="2xSmall" | ||
| {...beforeComponent.props} | ||
| {...styles.avatar} | ||
| data-testid="tag-before-component" |
src/components/Tag/Tag.tsx
Outdated
| > | ||
| {label} | ||
| </tet.p> | ||
| {!!onCloseClick && ( |
There was a problem hiding this comment.
Suggested change
| {!!onCloseClick && ( | |
| {hasCloseButton && ( |
MartaKozina010
temporarily deployed
to
development
GitHub Actions
Inactive
kudyniuk
approved these changes
Oct 9, 2023
|
PR moved to https://github.com/VirtusLab/tetrisly-react/pull/89/files on rebased (with main) branch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.